Rename children that refer to a MemberDeclBlock from members to memberBlock
#1524
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahoppen
added a commit
to ahoppen/swift-format
that referenced
this pull request
Apr 13, 2023
ahoppen
added a commit
to ahoppen/swift
that referenced
this pull request
Apr 13, 2023
ahoppen
added a commit
to ahoppen/swift-stress-tester
that referenced
this pull request
Apr 13, 2023
kimdv
approved these changes
Apr 13, 2023
bnbarham
approved these changes
Apr 13, 2023
ahoppen
added a commit
to ahoppen/swift-format
that referenced
this pull request
Apr 13, 2023
ahoppen
added a commit
to ahoppen/swift-stress-tester
that referenced
this pull request
Apr 13, 2023
ahoppen
added a commit
to ahoppen/swift
that referenced
this pull request
Apr 13, 2023
ahoppen
force-pushed
the
ahoppen/memberblock
branch
from
00c7cfb to
575c9f8
Compare
ahoppen
changed the title
MemberDeclBlock from members to memberBlock and MemberDeclBlock.members to itemsMemberDeclBlock from members to memberBlock
|
swiftlang/swift#65126 @swift-ci Please test Windows |
…memberBlock` Previously, we frequently had patterns where we did `node.members.members`, which doesn’t read very nice. `node.memberBlock.members` is much nicer.
ahoppen
force-pushed
the
ahoppen/memberblock
branch
from
575c9f8 to
5ba5cd3
Compare
|
swiftlang/swift#65126 @swift-ci Please test Windows |
4 similar comments
|
swiftlang/swift#65126 @swift-ci Please test Windows |
|
swiftlang/swift#65126 @swift-ci Please test Windows |
|
swiftlang/swift#65126 @swift-ci Please test Windows |
|
swiftlang/swift#65126 @swift-ci Please test Windows |
ahoppen
added a commit
to ahoppen/swift-syntax
that referenced
this pull request
Apr 18, 2023
Rename children that refer to a `MemberDeclBlock` from `members` to `memberBlock`
ahoppen
added a commit
to ahoppen/swift-syntax
that referenced
this pull request
Apr 18, 2023
Rename children that refer to a `MemberDeclBlock` from `members` to `memberBlock`
ahoppen
added a commit
to ahoppen/swift
that referenced
this pull request
Apr 18, 2023
ahoppen
added a commit
to ahoppen/swift-stress-tester
that referenced
this pull request
Apr 18, 2023
ahoppen
added a commit
to ahoppen/swift-format
that referenced
this pull request
Apr 18, 2023
meg-gupta
pushed a commit
to meg-gupta/swift
that referenced
this pull request
Apr 18, 2023
ahoppen
added a commit
to ahoppen/swift-stress-tester
that referenced
this pull request
Apr 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we frequently had patterns where we did
node.members.members, which doesn’t read very nice.node.memberBlock.membersis much nicer.