Add CMake build #73
Merged
Add CMake build #73
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `vm_page_size` variable declared in `mach/vm_page_size.h` is used when the header is available for inclusion. This header does not appear to be included anywhere directly resulting in build failures due to the missing `vm_page_size` declaration.
|
|
||
| FetchContent_Declare(SwiftSystem | ||
| GIT_REPOSITORY https://github.com/apple/swift-system.git | ||
| GIT_TAG a34201439c74b53f0fd71ef11741af7e7caf01e1 # 1.4.2 |
There was a problem hiding this comment.
@shahmishal @owenv FYI since we're currently trying to get this to 1.5.0.
Adding an initial CMake build for the Swift-subprocess library. At this time, it will build its own swift-system library, although we should allow it to search for one if one is available. CMake does not automatically generate modulemaps like SwiftPM does. As a result, we need to add one for Swift to import the C shims. There is one library target emitted from this build, Subprocess.
Adding steps to test that the CMake build works as expected.
Adding license header to the CMake files
Tell SwiftPM to ignore the CMake files to quiet the build warnings.
etcwilde
force-pushed
the
ewilde/cmake-build
branch
from
8989bec to
8121674
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a CMake build so that projects that use CMake to bootstrap, like SwiftPM and swift-build, can use this library.
This is an initial pass. Future work should include a mechanism to use a pre-built Swift-System and an installation story that generates a
SwiftSubprocessConfig.cmakefile. Changes are necessary in the Swift-System CMake files in order to have a proper installation story here though because the SwiftSystem library is not properly exported.Unlike SwiftPM, CMake does not automatically generate modulemaps for C headers, so we need to include one.
I'm not sure how the
mach/vm_page_size.hheader was getting included, but I was getting errors about thevm_page_sizevariable not being declared. If the header exists, include it so that variable is defined.Also added a workflow to verify that the CMake build continues to work.