Fix noCacheKeyConformance error on make-linux-sdk
#97
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow-up to 3e076d1 SystemString used inside FilePath is not a CacheKey, so the encoder complains about it, but we can consider FilePath as a leaf type and no need to encode it further.
|
@swift-ci test |
MaxDesiatov
added a commit
that referenced
this pull request
Aug 28, 2024
Follow-up to #97 with an added test case.
MaxDesiatov
added a commit
to swiftlang/swift-package-manager
that referenced
this pull request
Aug 28, 2024
This vendors fixes to `HashEncoder` from `swift-sdk-generator` introduced in swiftlang/swift-sdk-generator#97 and swiftlang/swift-sdk-generator#134.
MaxDesiatov
added a commit
that referenced
this pull request
Aug 28, 2024
Follow-up to #97 with an added test case.
MaxDesiatov
added a commit
to swiftlang/swift-package-manager
that referenced
this pull request
Aug 28, 2024
This vendors fixes to `HashEncoder` from `swift-sdk-generator` introduced in swiftlang/swift-sdk-generator#97 and swiftlang/swift-sdk-generator#134.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to 3e076d1
SystemString used inside FilePath is not a CacheKey, so the encoder complains about it, but we can consider FilePath as a leaf type and no need to encode it further.