generator: --from-container-image implies --with-docker #174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
MaxDesiatov
approved these changes
Jan 24, 2025
If --from-container-image is specified without --with-docker, the generator builds an SDK from Debian packages, completely ignoring the user's clear intent to build from a container image. For now, we can assume that a user who specifies --from-container-image also wants to use a container runtime. In future we might be able to support extracting container images without the need for a runtime. If that happens, we can stop assuming --with-docker and commands which only specify --from-container-image will continue to work, so scripts and documentation won't need to be changed.
euanh
force-pushed
the
implicit-with-docker
branch
from
c726e57 to
ac06500
Compare
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If --from-container-image is specified without --with-docker, the generator builds an SDK from Debian packages, completely ignoring the user's clear intent to build from a container image.
For now, we can assume that a user who specifies --from-container-image also wants to use a container runtime. In future we might be able to support extracting container images without the need for a
runtime. If that happens, we can stop assuming --with-docker
and commands which only specify --from-container-image will continue
to work, so scripts and documentation won't need to be changed.