test helpers: do not use default build system #8975
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
bkhouri
force-pushed
the
t/main/executeSwiftCommands_does_not_default_build_system
branch
from
7fe01c2 to
3a9edce
Compare
|
@swift-ci test |
bkhouri
force-pushed
the
t/main/executeSwiftCommands_does_not_default_build_system
branch
from
3a9edce to
a24442e
Compare
|
@swift-ci test |
|
@swift-ci test windows |
bkhouri
force-pushed
the
t/main/executeSwiftCommands_does_not_default_build_system
branch
from
a24442e to
a0b91c4
Compare
|
@swift-ci test |
|
@swift-ci test windows |
|
@swift-ci test self hosted windows |
bkhouri
force-pushed
the
t/main/executeSwiftCommands_does_not_default_build_system
branch
from
a0b91c4 to
5e5fb4b
Compare
|
@swift-ci test |
|
@swift-ci test windows |
bkhouri
force-pushed
the
t/main/executeSwiftCommands_does_not_default_build_system
branch
from
5e5fb4b to
2958992
Compare
|
@swift-ci test self hosted |
bkhouri
force-pushed
the
t/main/executeSwiftCommands_does_not_default_build_system
branch
from
2958992 to
e8f028f
Compare
|
@swift-ci test self hosted |
1 similar comment
|
@swift-ci test self hosted |
bkhouri
force-pushed
the
t/main/executeSwiftCommands_does_not_default_build_system
branch
from
0218a5d to
ba2b0e0
Compare
|
@swift-ci test self hosted |
This was referenced Jul 30, 2025
bkhouri
force-pushed
the
t/main/executeSwiftCommands_does_not_default_build_system
branch
from
ba2b0e0 to
a420bae
Compare
|
@swift-ci test |
bkhouri
force-pushed
the
t/main/executeSwiftCommands_does_not_default_build_system
branch
from
a420bae to
de79f86
Compare
|
@swift-ci test |
|
@swift-ci test windows |
bkhouri
requested review from
shawnhyam,
bripeticca,
plemarquand,
owenv,
cmcgee1024 and
daveyc123
as code owners
bkhouri
force-pushed
the
t/main/executeSwiftCommands_does_not_default_build_system
branch
from
de79f86 to
04360fb
Compare
|
@swift-ci test |
|
@swift-ci test windows |
bkhouri
force-pushed
the
t/main/executeSwiftCommands_does_not_default_build_system
branch
from
04360fb to
c8e9195
Compare
|
@swift-ci test |
|
@swift-ci test windows |
Many of the executeSwift* command helpers accept a build system provider, which was defaulted to the native build system. Since we are augmenting the tests to also run against the SwiftBuild, setting a default value may lead to an undesirable test behaviour. Update all the executeSwift* commands to no set a default build system provider, and update SwiftBuild tests accordingly.
bkhouri
force-pushed
the
t/main/executeSwiftCommands_does_not_default_build_system
branch
from
c8e9195 to
2aab96f
Compare
|
@swift-ci test |
|
@swift-ci test windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many of the
executeSwift*command helpers accept a build system provider, which was defaulted to the native build system. Since we are augmenting the tests to also run against the SwiftBuild, setting a default value may lead to an undesirable test behaviour.Update all the
executeSwift*commands to no set a default build system provider.