Tests: Augment TraitTests to support SwiftBuild #8813
Merged
+301
−156
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
bkhouri
force-pushed
the
t/main/migrate_traits_to_swift_testing_and_add_swiftbuild_support
branch
from
a6e7413 to
bf2a051
Compare
|
@swift-ci test |
|
@swift-ci test self hosted |
|
@swift-ci test windows |
In the process of updating the TraitTests to add test support for the Swift Build build system, migrate the test Suite to Swift Testing, making use of parameterized tests to reduce duplication and use `withKnownIssue`` to get signal when tests have been fixed.
bkhouri
force-pushed
the
t/main/migrate_traits_to_swift_testing_and_add_swiftbuild_support
branch
from
bf2a051 to
51cccf6
Compare
|
@swift-ci test |
|
@swift-ci test windows |
bkhouri
requested review from
jakepetroules,
dschaefer2,
shawnhyam,
bripeticca,
plemarquand,
owenv,
cmcgee1024 and
daveyc123
as code owners
cmcgee1024
reviewed
Jun 17, 2025
| skipPlatformCi: true, | ||
| ) | ||
| @Suite( | ||
| // .serialized, // to limit the number of swift executable running. |
There was a problem hiding this comment.
question: can this comment be removed since the test suite will be running in parallel mode, not serialized?
cmcgee1024
reviewed
Jun 17, 2025
| func traits_whenNoFlagPassed( | ||
| buildSystem: BuildSystemProvider.Kind, | ||
| ) async throws { | ||
| try await withKnownIssue { | ||
| try await fixture(name: "Traits") { fixturePath in |
There was a problem hiding this comment.
nitpick: This section be indented one level deeper here underneath the withKnownIssue.
There was a problem hiding this comment.
this was done purposely with a few tests so so the diff is smaller won't show the whitespaces once the withKnownIssue has been resolved.
cmcgee1024
approved these changes
Jun 17, 2025
bripeticca
approved these changes
Jun 17, 2025
bkhouri
deleted the
t/main/migrate_traits_to_swift_testing_and_add_swiftbuild_support
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the process of updating the TraitTests to add test support for the Swift Build build system, migrate the test Suite to Swift Testing, making use of parameterized tests to reduce duplication and use
withKnownIssueto get signal when tests have been fixed.Depends on: #8714