Ensure prebuilt Modules include path added to generated modules #8485
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For Windows and Linux, SwiftPM generates modules for test discovery and the test entry point. When testing macro targets, we add the swift-syntax prebuilt Modules directory to the include path for the test target. We also need to do this for the generated modules. As a side effect, this also adds all include directories to the include path for these generated modules to ensure they build for other use cases that may need this.
dschaefer2
requested review from
MaxDesiatov,
bkhouri,
bnbarham,
bripeticca,
francescomikulis,
jakepetroules,
owenv,
plemarquand,
shawnhyam and
xedin
as code owners
Member
Author
|
@swift-ci please test linux |
cmcgee1024
approved these changes
Apr 14, 2025
jakepetroules
approved these changes
Apr 16, 2025
dschaefer2
added a commit
to dschaefer2/swift-package-manager
that referenced
this pull request
Apr 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Windows and Linux, SwiftPM generates modules for test discovery and the test entry point. When testing macro targets, we add the swift-syntax prebuilt Modules directory to the include path for the test target. We also need to do this for the generated modules.
As a side effect, this also adds all include directories to the include path for these generated modules to ensure they build for other use cases that may need this.