Make sure the workspace state is saved after adding/removing artifacts. #8475
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shawnhyam
requested review from
bnbarham,
MaxDesiatov,
jakepetroules,
xedin,
dschaefer2,
bripeticca,
plemarquand,
owenv,
bkhouri,
cmcgee1024 and
daveyc123
as code owners
bkhouri
approved these changes
Apr 10, 2025
|
@swift-ci please test |
|
@swift-ci test self hosted windows |
plemarquand
approved these changes
Apr 10, 2025
|
@swift-ci please test |
|
@swift-ci please test windows |
|
@swift-ci please test self hosted windows |
|
I was wondering about withAsyncThrowing. Is that available in Swift 6.0? Appears to be what the Windows failure is about. |
It's a function in swift-package-manager, in Sources/Basics/Concurrency/ThrowingDefer.swift |
|
@swift-ci please test windows |
|
@swift-ci please test self hosted windows |
|
@swift-ci please test |
|
@swift-ci please test windows |
|
@swift-ci test self hosted windows |
|
@swift-ci test self hosted windows |
|
@swift-ci test |
|
@swift-ci please test windows |
|
@swift-ci please test windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The workspace state needs to be saved even if the updateBinaryArtifacts call exits early.
Motivation:
If we delete old artifacts, and then the new versions fail to download, without a save() call the workspace state will not know the artifact is no longer there.
Modifications:
Move the
save()call to adeferblock so it always gets called.Result:
There should be fewer inconsistencies between workspace state and what is actually on disk.