Implement --enable-parseable-module-interfaces for swift-build buildsystem #8421
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
daveinglis
force-pushed
the
pr/parseable_module
branch
from
395acee to
4047680
Compare
|
@swift-ci test |
daveinglis
force-pushed
the
pr/parseable_module
branch
from
4047680 to
0392765
Compare
|
@swift-ci test |
daveinglis
force-pushed
the
pr/parseable_module
branch
from
0392765 to
c74d017
Compare
|
@swift-ci test |
daveinglis
force-pushed
the
pr/parseable_module
branch
from
c74d017 to
32b7a28
Compare
bkhouri
reviewed
Mar 31, 2025
| @@ -70,7 +70,19 @@ class BuildCommandTestCases: CommandsBuildProviderTestCase { | |||
| // is what `binContents` is meant to represent. | |||
| return contents != ["output-file-map.json"] | |||
| } | |||
| let moduleContents = (try? localFileSystem.getDirectoryContents(binPath.appending(component: "Modules"))) ?? [] | |||
| var moduleContents: [String] = [] | |||
| if buildSystemProvider == .native { | |||
There was a problem hiding this comment.
suggestion: instead of creating an if statement to control the behaviour of the build function, can we instead call a function that is overridden in the sub classes?
There was a problem hiding this comment.
I think this should wait since we will be moving to swift testing, we can refactor these tests better.
| @@ -190,48 +202,6 @@ class BuildCommandTestCases: CommandsBuildProviderTestCase { | |||
| } | |||
| } | |||
|
|
|||
| func testBinSymlink() async throws { | |||
There was a problem hiding this comment.
suggestion: In order to ensure the "concrete" class implement this this, can we keep an implementation that will fail, forcing the subclasses to implement the test?
This way, we are guaranteed that each sub-class will implement this test.
…ystem - this also fixes -enable-library-evolution when used as a unsafeFlags Closes: 8337
daveinglis
force-pushed
the
pr/parseable_module
branch
from
32b7a28 to
6420013
Compare
|
@swift-ci test |
1 similar comment
|
@swift-ci test |
|
@swift-ci please test self hosted windows |
daveinglis
requested review from
bnbarham,
MaxDesiatov,
jakepetroules,
xedin,
dschaefer2,
shawnhyam,
bripeticca,
plemarquand,
owenv,
cmcgee1024 and
daveyc123
as code owners
bkhouri
approved these changes
Apr 7, 2025
|
@swift-ci test |
johnbute
pushed a commit
to johnbute/fork-swift-package-manager
that referenced
this pull request
Apr 17, 2025
…ystem (swiftlang#8421) - this also fixes -enable-library-evolution when used as a unsafeFlags Closes: swiftlang#8337 ### Modifications: sets SWIFT_EMIT_MODULE_INTERFACE build setting when option is set ### Result: the build option will include the .swftinertface files in the module folder
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #8337
Modifications:
sets SWIFT_EMIT_MODULE_INTERFACE build setting when option is set
Result:
the build option will include the .swftinertface files in the module folder