Skip to content

[6.1] Add a new BuildDescription.load API for use in SourceKit-LSP #8296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 19, 2025
Merged

[6.1] Add a new BuildDescription.load API for use in SourceKit-LSP #8296

merged 1 commit into from
Feb 19, 2025

Conversation

bnbarham
Copy link
Contributor

  • Explanation: Build tool plugins need to be built and run as part of the build plan generation. Rather than relying on clients to do so, add a new API that does both.
  • Scope: LSP API
  • Issue: rdar://102242345
  • Original PR: Add a new BuildDescription.load API for use in SourceKit-LSP #8286
  • Risk: Extremely low - adds an API
  • Testing: New tests + integration tests in LSP to test this functionality
  • Reviewer: @xedin

@bnbarham
Add a new BuildDescription.load API for use in SourceKit-LSP
abbcabe 
Build tool plugins need to be built and run as part of the build plan
generation. Rather than relying on clients to do so, add a new API that
does both. This does unfortunately expose much more of the SwiftPM API
than previously, but given it is all required to a generate a
`BuildPlan`, this was really already the case.

Long term this module should be replaced by a long-running BSP server
that can prepare and provide build settings in the one process.

Resolves rdar://102242345.

(cherry picked from commit 4fa0769)
@bnbarham bnbarham mentioned this pull request Feb 14, 2025
Merged
@bnbarham
Copy link
Contributor Author

swiftlang/sourcekit-lsp#1981

@swift-ci please test

1 similar comment
@bnbarham
Copy link
Contributor Author

swiftlang/sourcekit-lsp#1981

@swift-ci please test

@bnbarham bnbarham merged commit e0c6ff2 into swiftlang:release/6.1 Feb 19, 2025
5 checks passed
@bnbarham bnbarham deleted the 6.1-plan-should-build-tool-plugins branch February 19, 2025 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakepetroules jakepetroules jakepetroules approved these changes

@MaxDesiatov MaxDesiatov Awaiting requested review from MaxDesiatov MaxDesiatov is a code owner

@francescomikulis francescomikulis Awaiting requested review from francescomikulis francescomikulis is a code owner

@xedin xedin Awaiting requested review from xedin xedin is a code owner

@dschaefer2 dschaefer2 Awaiting requested review from dschaefer2 dschaefer2 is a code owner

@shawnhyam shawnhyam Awaiting requested review from shawnhyam shawnhyam is a code owner

@bripeticca bripeticca Awaiting requested review from bripeticca bripeticca is a code owner

@plemarquand plemarquand Awaiting requested review from plemarquand plemarquand is a code owner

@owenv owenv Awaiting requested review from owenv owenv is a code owner

@bkhouri bkhouri Awaiting requested review from bkhouri bkhouri is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bnbarham @jakepetroules