Skip to content

[6.1] Add include dir from a clang module into the build args. #8241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 23, 2025
Merged

[6.1] Add include dir from a clang module into the build args. #8241

merged 1 commit into from
Jan 23, 2025

Conversation

yyvch
Copy link
Contributor

@yyvch yyvch commented Jan 22, 2025 •
edited
Loading

@yyvch
Add include dir from a clang module into the build args.
7fcafab 
Each clang module has public `include` dir. When building current module
then it typically works as-is, but when a module has non-standard
source location, then explicit include of `include` is necessary.
@yyvch
Copy link
Contributor Author

yyvch commented Jan 22, 2025

@swift-ci please test

@bkhouri bkhouri merged commit 979610a into swiftlang:release/6.1 Jan 23, 2025
5 checks passed
@yyvch yyvch deleted the pr8209-cp61 branch February 19, 2025 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bkhouri bkhouri bkhouri approved these changes

@bnbarham bnbarham Awaiting requested review from bnbarham bnbarham is a code owner

@MaxDesiatov MaxDesiatov Awaiting requested review from MaxDesiatov MaxDesiatov is a code owner

@jakepetroules jakepetroules Awaiting requested review from jakepetroules jakepetroules is a code owner

@francescomikulis francescomikulis Awaiting requested review from francescomikulis francescomikulis is a code owner

@xedin xedin Awaiting requested review from xedin xedin is a code owner

@dschaefer2 dschaefer2 Awaiting requested review from dschaefer2 dschaefer2 is a code owner

@shawnhyam shawnhyam Awaiting requested review from shawnhyam shawnhyam is a code owner

@bripeticca bripeticca Awaiting requested review from bripeticca bripeticca is a code owner

@plemarquand plemarquand Awaiting requested review from plemarquand plemarquand is a code owner

@owenv owenv Awaiting requested review from owenv owenv is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yyvch @bkhouri