Tests: Skip failing tests on windows #8210
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
compnerd
reviewed
Jan 21, 2025
The Pipelines do not currently test on windows platform. To get to a point where we can execute tests on windows, we will first disable the failing tests and later enable them as the pipeline is setup to ensure we do not regress in behaviour. related to swiftlang#8121 rdar://139977454
bkhouri
force-pushed
the
t/main/gh8121_radar139977454_swift_test_on_windows
branch
from
27afed4 to
09a6835
Compare
…hich does not compile on Windows
…APITests.testLoadPackage to have windows path
1 task
bkhouri
force-pushed
the
t/main/gh8121_radar139977454_swift_test_on_windows
branch
from
5e027e0 to
293fc93
Compare
bkhouri
commented
Mar 19, 2025
| @@ -28,7 +28,23 @@ import struct TSCBasic.ByteString | |||
| import struct TSCUtility.Version | |||
|
|
|||
| final class WorkspaceTests: XCTestCase { | |||
| // override func setUpWithError() throws { | |||
There was a problem hiding this comment.
chore (blocking): remove commented code
…on_darwin logic outside the run_bootstrap call
…139977454_swift_test_on_windows
|
@swift-ci please test self hosted windows |
…139977454_swift_test_on_windows
|
@swift-ci please test self hosted windows |
1 similar comment
|
@swift-ci please test self hosted windows |
|
@swift-ci please test |
bkhouri
changed the title
bkhouri
requested review from
bnbarham,
MaxDesiatov,
xedin,
dschaefer2,
shawnhyam,
bripeticca,
plemarquand,
owenv,
cmcgee1024 and
daveyc123
as code owners
|
@swift-ci please test windows |
compnerd
approved these changes
Mar 28, 2025
|
This might be true. I did not actually investigate all the tests failure. My goal was to get a pipeline up and running with currently passing tests. The next step will be to re-enable the automated tests on Windows. I know a bunch of tests failure have to do with "path" issues, so fixing that will likely re-enable alot of tests (assuming the are no other test failure). |
dschaefer2
approved these changes
Mar 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Pipelines do not currently test on windows platform. To get to a point where we can execute tests on windows, we will first disable the failing tests and later enable them as the pipeline is setup to ensure we do not regress in behaviour.
related to #8121
rdar://139977454
Motivation:
In preparation for #8176 , disable failing Windows tests.
Modifications:
Mark some tests as Skipped on Windows
Fixes #8176