pipeline: changes to support nightly toolchain #8161
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
|
@swift-ci Please test nightly self hosted |
bkhouri
force-pushed
the
t/main/update_test_to_support_nightly_toolchain
branch
5 times, most recently
from
0041735 to
d128b12
Compare
|
@swift-ci Please test nightly self hosted |
bkhouri
force-pushed
the
t/main/update_test_to_support_nightly_toolchain
branch
4 times, most recently
from
ca70f24 to
9d95883
Compare
|
@swift-ci please test nightly self hosted |
bkhouri
force-pushed
the
t/main/update_test_to_support_nightly_toolchain
branch
from
9d95883 to
4f4ff6f
Compare
|
@swift-ci Please test nightly self hosted |
bkhouri
force-pushed
the
t/main/update_test_to_support_nightly_toolchain
branch
from
4f4ff6f to
229ce09
Compare
|
@swift-ci Please test nightly self hosted |
bkhouri
force-pushed
the
t/main/update_test_to_support_nightly_toolchain
branch
from
229ce09 to
81606a8
Compare
|
@swift-ci Please test nightly self hosted |
bkhouri
force-pushed
the
t/main/update_test_to_support_nightly_toolchain
branch
from
81606a8 to
ff887d9
Compare
|
@swift-ci Please test nightly self hosted |
bkhouri
force-pushed
the
t/main/update_test_to_support_nightly_toolchain
branch
from
ff887d9 to
e387498
Compare
bkhouri
changed the title
|
@swift-ci please test |
|
@swift-ci Please test nightly self hosted |
Make changes to ensure success of the self-hosted macOS pipeline that executes using the nightly toolchain. 1/ Set SDKROOT in build-using-self when on Darwin When using the nighlty toolchain, the SDKROOT environment variable was not set. Explicitely set this to the default xcode installation only when on Darwin. 2/ Run the testTestsCanLinkAgainstAsyncExecutable only if it's executed on macOS 15 or never. 3/ Add additional logging to troubleshoot the bootstap failure and convert to use python's logging module instead of print statements.
bkhouri
force-pushed
the
t/main/update_test_to_support_nightly_toolchain
branch
from
e387498 to
5a56aa0
Compare
|
@swift-ci Please test nightly self hosted |
bkhouri
force-pushed
the
t/main/update_test_to_support_nightly_toolchain
branch
from
5a56aa0 to
4b83823
Compare
|
@swift-ci Please test nightly self hosted |
|
@swift-ci please test |
bkhouri
requested review from
bnbarham,
MaxDesiatov,
francescomikulis,
xedin,
dschaefer2,
shawnhyam,
bripeticca,
plemarquand and
owenv
as code owners
|
@swift-ci please test windows |
bnbarham
approved these changes
Dec 17, 2024
jakepetroules
approved these changes
Dec 17, 2024
shahmishal
reviewed
Dec 18, 2024
| set -x | ||
|
|
||
| env | sort |
There was a problem hiding this comment.
Do we need this? I assume it was for debugging?
There was a problem hiding this comment.
Primarily informative information. I think it's valuable to have.
bkhouri
added a commit
to bkhouri/swift-package-manager
that referenced
this pull request
Feb 7, 2025
The `Utilities/bootstrap` script is no longer emitting Swift PM build status information. This change reverted the swiftlang#8161 and then converted the print calls to use python's logging module. Fixes swiftlang#8281
bkhouri
added a commit
to bkhouri/swift-package-manager
that referenced
this pull request
Feb 10, 2025
The `Utilities/bootstrap` script is no longer emitting Swift PM build status information. This change reverted the swiftlang#8161 and then converted the print calls to use python's logging module. Fixes swiftlang#8281
bkhouri
added a commit
to bkhouri/swift-package-manager
that referenced
this pull request
Feb 11, 2025
The `Utilities/bootstrap` script is no longer emitting Swift PM build status information. This change reverted the swiftlang#8161 and then converted the print calls to use python's logging module. Fixes swiftlang#8281
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make changes to ensure success of the self-hosted macOS pipeline that executes using the nightly toolchain.
Motivation:
When enabling the nightly toolchain build, the CI build does not set SDKROOT environment variable on Darwin, which causes some tests to fail
Modifications:
SDKROOTenvironment variable was not set. Explicitely set this to the default xcode installation only when on Darwin.Verifies #8137