Flush Utilities/bootstrap script logging output
#8141
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As `Utilities/helpers.py` output of `print` is not immediately flushed, it makes debugging of this script very hard, since logging messages are not guaranteed to be printed in correct order.
MaxDesiatov
requested review from
bnbarham,
jakepetroules,
francescomikulis,
xedin,
dschaefer2,
shawnhyam,
bripeticca,
plemarquand and
owenv
as code owners
|
@swift-ci test |
plemarquand
approved these changes
Nov 27, 2024
|
@swift-ci test windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
As
Utilities/helpers.pyoutput ofprintis not immediately flushed, it makes debugging ofUtilities/bootstrapscript very hard, since logging messages are not guaranteed to be printed in correct order.Modifications:
All calls to
printinUtilities/helpers.pyhaveflush=Truepassed as arguments.Result:
Messages logged in the bootstrap script are always printed in the correct order.