Add basic support for plugins in swift-bootstrap script #8128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owenv
requested review from
bnbarham,
MaxDesiatov,
jakepetroules,
francescomikulis,
xedin,
dschaefer2,
shawnhyam,
bripeticca and
plemarquand
as code owners
|
@swift-ci please test |
jakepetroules
approved these changes
Nov 19, 2024
|
@swift-ci please test Linux |
|
@swift-ci please test Windows |
dschaefer2
approved these changes
Nov 19, 2024
|
Ci breakage should be resolved now @swift-ci please test |
owenv
force-pushed
the
pr/owenv/bootstrap-plugin-fixes
branch
from
1407f61 to
78a9425
Compare
|
@swift-ci please test |
|
@swift-ci please test Windows |
|
@swift-ci please test Linux |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add basic support for plugins to swift-bootstrap so that any plugins added to dependencies aren't silently dropped from the build plan, which could cause confusing errors related to nonexistent targets.