Expose all target files to SourceKit-LSP #8107
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewbastien
requested review from
bnbarham,
MaxDesiatov,
jakepetroules,
francescomikulis,
xedin,
dschaefer2,
shawnhyam,
bripeticca,
plemarquand and
owenv
as code owners
|
Would you mind adding tests that cover the new APIs? |
MaxDesiatov
added
needs tests
plemarquand
approved these changes
Nov 7, 2024
|
@swift-ci please test |
|
@swift-ci test |
|
@swift-ci test windows |
MaxDesiatov
reviewed
Nov 7, 2024
MaxDesiatov
reviewed
Nov 7, 2024
MaxDesiatov
reviewed
Nov 7, 2024
MaxDesiatov
reviewed
Nov 7, 2024
MaxDesiatov
reviewed
Nov 7, 2024
|
@swift-ci test |
|
@swift-ci test windows |
|
@swift-ci please test |
|
@swift-ci please test windows |
ahoppen
reviewed
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
resources,ignored, andotherfiles toBuildTargetfor use by SourceKit-LSP.This is tracked by rdar://139431738 as part of swiftlang/vscode-swift#562
Motivation:
SourceKit-LSP needs to be able to determine which target contains a given DocC catalog in order to fulfill documentation related requests. However, the catalog is not listed as one of the
sourcesorheaders. Rather, it is part ofotherfiles in most cases. Expose all file types to SourceKit-LSP so that it can properly determine which target a given file belongs to.Modifications:
Added three new properties to
BuildTarget:resources,ignored, andotherwhich are arrays ofURLpointing to the given file types in the target.Result:
SourceKit-LSP will be able to see all files contained within a given target.