[Build] NFC: Remove uses of buildTriple from computeDependencies(of:)
#7888
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f:)` Now that we have all the tools to compute destinations for dependencies of a product, we no longer need `buildTriple` here and dynamic/static library results could be represented by build descriptions as a bonus.
xedin
requested review from
bnbarham,
MaxDesiatov,
jakepetroules,
francescomikulis,
dschaefer2,
shawnhyam,
bripeticca,
plemarquand and
owenv
as code owners
|
@swift-ci please test |
MaxDesiatov
approved these changes
Aug 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Now that we have all the tools to compute destinations for dependencies of a product,
we no longer need
buildTriplehere and dynamic/static library results could be representedby build descriptions as a bonus.
Modifications:
BuildPlan.computeDependencies(of:)has been updated to take aProductBuildDescriptionand use depth first scan that computes destination;Result:
One more use of
buildTripleis gone.