[BuildPlan] Add a way to traverse the graph and compute destinations for all modules #7868
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xedin
requested review from
bnbarham,
MaxDesiatov,
jakepetroules and
francescomikulis
as code owners
|
swiftlang/sourcekit-lsp#1621 |
|
swiftlang/sourcekit-lsp#1621 |
1 similar comment
|
swiftlang/sourcekit-lsp#1621 |
xedin
force-pushed
the
build-plan-traverse-modules
branch
from
ed2e021 to
e3b64f9
Compare
|
swiftlang/sourcekit-lsp#1621 |
|
swiftlang/sourcekit-lsp#1621 |
|
swiftlang/sourcekit-lsp#1621 |
1 similar comment
|
swiftlang/sourcekit-lsp#1621 |
MaxDesiatov
reviewed
Aug 9, 2024
MaxDesiatov
reviewed
Aug 9, 2024
MaxDesiatov
reviewed
Aug 9, 2024
MaxDesiatov
approved these changes
Aug 9, 2024
…for all modules This is going to be used by sourcekit-lsp to build a graph/dictionary of all the targets and depths they appear during package loading and replaces the need for topological sort and `buildTriple`.
xedin
force-pushed
the
build-plan-traverse-modules
branch
from
e3b64f9 to
1b352ac
Compare
|
swiftlang/sourcekit-lsp#1621 |
|
swiftlang/sourcekit-lsp#1621 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
This is going to be used by sourcekit-lsp to build a graph/dictionary
of all the targets and depths they appear during package loading and
replaces the need for topological sort and
buildTriple.Modifications:
depthFirstSearchvariant which traverses all of the nodes in the graph.BuildPlan-traverseModuleswhich goes over the graph, computes destinations and returns modules with their parents and depths they appear at (the method looks though products).Result:
This make it possible to switch sourcekit-lsp away from using topological sort and relying on
buildTriple.Paired with swiftlang/sourcekit-lsp#1621