[Build/Commands] Switch SymbolGraphExtract to use build plan
#7863
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xedin
requested review from
bnbarham,
MaxDesiatov,
jakepetroules and
francescomikulis
as code owners
|
@swift-ci please test |
rauhul
reviewed
Aug 7, 2024
| @@ -121,7 +136,7 @@ public enum ModuleBuildDescription { | |||
|
|
|||
| /// Determines the arguments needed to run `swift-symbolgraph-extract` for | |||
| /// this module. | |||
| package func symbolGraphExtractArguments() throws -> [String] { | |||
| public func symbolGraphExtractArguments() throws -> [String] { | |||
There was a problem hiding this comment.
Because it’s a witness to a public protocol requirement now
rauhul
reviewed
Aug 7, 2024
rauhul
reviewed
Aug 7, 2024
xedin
commented
Aug 7, 2024
| @@ -216,6 +216,10 @@ public class BuildPlan: SPMBuildCore.BuildPlan { | |||
| AnySequence(self.productMap.values.map { $0 as SPMBuildCore.ProductBuildDescription }) | |||
| } | |||
|
|
|||
| public var buildModules: AnySequence<SPMBuildCore.ModuleBuildDescription> { | |||
There was a problem hiding this comment.
The other member uses AnySequence so I used the same for consistency.
rauhul
reviewed
Aug 7, 2024
MaxDesiatov
approved these changes
Aug 7, 2024
Yet another step on the path to remove `buildTriple` from `Resolved{Product, Module}`.
Instead of trying to lookup modules in the module graph and then going
the build plan for their descriptions, symbol-graph-extract should refer
to the build plan directly.
xedin
force-pushed
the
symbol-graph-loves-build-plan
branch
from
b8d848e to
3faf021
Compare
|
@swift-ci please test |
|
@swift-ci please test Windows platforms |
rauhul
approved these changes
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Yet another step on the path to remove
buildTriplefromResolved{Product, Module}.Motivation:
Instead of trying to lookup modules in the module graph and then going the build plan for their descriptions, symbol-graph-extract should refer to the build plan directly.
Modifications:
ModuleBuildDescriptionto SPMBuildCoreBuild.ModuleBuildDescriptiontoSPMCore.ModuleBuildDescriptionResult:
One less place that replies on
buildTriplewhich brings us closer to its eventual removal.