Add async-friendly WritableStream, create _AsyncFileSystem module
#7831
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Existing `WritableByteStream` protocol used by `AsyncProcess` is not thread-safe. It's new `WritableStream` replacement is, with an added conformance to the existing `OpenWritableFile`. That one is built on top `AsyncFS`, which has been moved to the `Basics` module. That allows us to adopt it in `AsyncProcess` in the future.
MaxDesiatov
added
concurrency
no functional change
|
@swift-ci test |
MaxDesiatov
commented
Jul 28, 2024
|
@swift-ci test |
|
@swift-ci test windows |
MaxDesiatov
changed the title
async-friendly WritableStream, move AsyncFS to Basicsasync-friendly WritableStream, create _AsyncFileSystem module
|
@swift-ci test |
|
@swift-ci test windows |
|
@swift-ci test |
MaxDesiatov
removed
needs tests
|
@swift-ci test |
MaxDesiatov
requested review from
bnbarham,
jakepetroules,
francescomikulis and
xedin
as code owners
|
@swift-ci test windows |
MaxDesiatov
commented
Jul 29, 2024
|
@swift-ci test |
|
@swift-ci test windows |
|
@swift-ci please test |
xedin
approved these changes
Aug 7, 2024
…o maxd/async-fs-basics
|
@swift-ci test |
|
@swift-ci test windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Existing
WritableByteStreamprotocol used byAsyncProcessis not thread-safe. It's newWritableStreamreplacement is, with an added conformance to the existingOpenWritableFile. That one is built on topAsyncFS, which has been moved to theBasicsmodule. That allows us to adopt it inAsyncProcessin the future.This is NFC, new API is adopted solely by
QueryEngine, which is exercised only in tests.