[6.0][PackageLoading] Support deserialization of manifests that used `swif… #7828
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tLanguageVersion` Follow-up to swiftlang#7620 This is important for the manifest cache - make sure that older manifests that used original spelling of the build setting are still deserializable. (cherry picked from commit 5189086)
bnbarham
approved these changes
Jul 26, 2024
|
@swift-ci please test |
|
@swift-ci please test Windows platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…tLanguageVersion`
Explanation:
Follow-up to Adopt language mode naming in
PackageDescriptionAPI #7620This is important for the manifest cache - make sure that older manifests that used original spelling of the build setting are still deserializable.
Main Branch PR: [PackageLoading] Support deserialization of manifests that used `swif… #7827
Resolves: rdar://132484168
Risk: Very Low (This change is very narrow and affects only people who adopted
swiftLanguagVersionwhile building with 6.0 snapshot and had their manifests cached).Reviewed By: @bnbarham
Testing: Local testing only since there are no convenient affordances to test this.
(cherry picked from commit 5189086)