[Build] NFC: Compute per-module macro requirements on-demand #7812
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of having to go over all of the products and establish
module -> product
relationships during build plan construction let swift module build descriptions compute required macros based on their underlying modules as necessary.Motivation:
Build plan is required to pre-compute macro requirements but that's expensive and shouldn't be necessary.
Modifications:
SwiftModuleBuildDescription
all we need to pass are build parameters to use for macros and the macros themselves could be found based on the underlying module.Result:
Build plan construction is slightly simpler and less expensive to compute, product and module descriptions could now be computed independently.