Skip to content

Revert "Fix: use bearer auth when pulling binaryTarget or packages from a package registry" #7811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 4, 2024

Conversation

MaxDesiatov
Copy link
Contributor

@MaxDesiatov MaxDesiatov commented Jul 23, 2024

Reverts #7662

It would be a breaking change if someone is using token as their username, and we don't have a migration path or any other means to clarify this breaking change to the users.

@MaxDesiatov
Copy link
Contributor Author

@swift-ci test

@xedin
Copy link
Contributor

xedin commented Sep 3, 2024

@swift-ci please test

@MaxDesiatov MaxDesiatov enabled auto-merge (squash) September 3, 2024 16:39
@MaxDesiatov
Copy link
Contributor Author

@swift-ci test macos

@MaxDesiatov
Copy link
Contributor Author

cc @pwallrich as the original author. Happy to review an alternative solution that would not introduce breaking changes such as this one.

@MaxDesiatov MaxDesiatov merged commit 4f724fa into main Sep 4, 2024
5 checks passed
@MaxDesiatov MaxDesiatov deleted the revert-7662-fix/bearer-auth branch September 4, 2024 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants