[6.0] Fix host/target products with --static-swift-stdlib
#7743
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dlib` (#7695) ### Motivation: Given the following conditions: - `--static-swift-stdlib` is enabled (it only affects "target" destination products, "host" destination products are always dynamic) - the building subset contains both "host" and "target" destination products derived from the same product. - the product imports `Foundation` (that has private dependency libs) then the build randomly failed due to the race condition of the Objects.LinkFileList creation. Reproducible project https://github.com/kateinoigakukun/swift-autolink-issue-repro ### Modifications: This commit fixes the issue by distinguishing the temporary link file list response file name by the `-tool` suffix. I think it would be better to add assertions in `LLBuildManifest` to avoid such unintentional target overwrites later. ### Result: Fix the build for the above case. (cherry picked from commit e858647)
MaxDesiatov
added
bug
plugins
cross-compilation
swift 6.0
|
@swift-ci test |
bnbarham
approved these changes
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #7695.
Explanation: Given the following conditions:
--static-swift-stdlibis enabled (it only affects "target" destination products, "host" destination products are always dynamic)Foundation(that has private dependency libs)then the build randomly failed due to the race condition of the
Objects.LinkFileListcreation.Reproducible project
https://github.com/kateinoigakukun/swift-autolink-issue-repro
Scope: isolated to packages with plugins
Risk: low, the change was incubated on
mainfor a few weeks nowTesting: Added a new automated test case
Issue: N/A
Reviewer: @MaxDesiatov