Skip to content

[DNM] Test Logging #7742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

[DNM] Test Logging #7742

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c0969ae
Manifest loading logging
jmschonfeld Jul 2, 2024
66e053b
More logging
jmschonfeld Jul 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion Sources/PackageLoading/ManifestLoader.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -977,6 +977,7 @@ public final class ManifestLoader: ManifestLoaderProtocol {

// Return now if there was an error.
if compilerResult.exitStatus != .terminated(code: 0) {
evaluationResult.compilerOutput = (evaluationResult.compilerOutput ?? "") + " (compiler exited with \(compilerResult.exitStatus))"
return completion(.success(evaluationResult))
}

Expand Down Expand Up @@ -1081,7 +1082,7 @@ public final class ManifestLoader: ManifestLoaderProtocol {
if runResult.exitStatus != .terminated(code: 0) {
// TODO: should this simply be an error?
// return completion(.failure(AsyncProcessResult.Error.nonZeroExit(runResult)))
evaluationResult.errorOutput = evaluationResult.compilerOutput
evaluationResult.errorOutput = (evaluationResult.compilerOutput ?? "<no compiler output>") + " running the manifest executable exited with a non-zero exit code: \(runResult.exitStatus)"
return completion(.success(evaluationResult))
}

Expand Down