Skip to content

[Traits] Enable trait configuration for swift-test #7704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

FranzBusch
Copy link
Member

Motivation

It is useful to be able to configure the traits of the root package when running tests.

Modification

This PR adds the trait CLI options to the swift test command to enable specific traits or all traits, or to disable the default traits.

Result

swift test now supports configuring the root traits.

Copy link
Contributor

@MaxDesiatov MaxDesiatov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@FranzBusch
Copy link
Member Author

@swift-ci please test

@FranzBusch
Copy link
Member Author

@swift-ci test windows

@FranzBusch FranzBusch enabled auto-merge (squash) June 24, 2024 14:46
@FranzBusch FranzBusch force-pushed the fb-traits-swift-test branch from 6766798 to 930ee85 Compare June 24, 2024 14:59
@FranzBusch
Copy link
Member Author

@swift-ci please test

@FranzBusch
Copy link
Member Author

@swift-ci please test

@FranzBusch FranzBusch force-pushed the fb-traits-swift-test branch from 930ee85 to 29e30de Compare June 24, 2024 16:11
@FranzBusch
Copy link
Member Author

@swift-ci please test

# Motivation

It is useful to be able to configure the traits of the root package when running tests.

# Modification

This PR adds the trait CLI options to the `swift test` command to enable specific traits or all traits, or to disable the default traits.

# Result

`swift test` now supports configuring the root traits.
@FranzBusch FranzBusch force-pushed the fb-traits-swift-test branch from 29e30de to 5247e2f Compare June 24, 2024 16:24
@FranzBusch
Copy link
Member Author

@swift-ci please test

@FranzBusch
Copy link
Member Author

@swift-ci test windows

1 similar comment
@FranzBusch
Copy link
Member Author

@swift-ci test windows

@FranzBusch FranzBusch merged commit 59b6648 into swiftlang:main Jun 25, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants