[6.0] Fix cache not cleaned up if download fails #7671
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the download of a binaryTarget fails a cache file still remains in the artifact cache. The file only contains the server's response which is usually the status code and the error message. All following resolve calls therefore fail because the cached file is used but is an invalid archive (cherry picked from commit ee48da5)
(cherry picked from commit 809c405)
MaxDesiatov
changed the title
MaxDesiatov
changed the title
|
@swift-ci test |
bnbarham
approved these changes
Jun 17, 2024
| @@ -618,6 +618,9 @@ extension Workspace { | |||
| progress: progress, | |||
| completion: { result in | |||
| self.delegate?.willDownloadBinaryArtifact(from: artifact.url.absoluteString, fromCache: false) | |||
There was a problem hiding this comment.
Isn't it already downloaded at this point?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #7663.
Explanation: If a server returns an error when trying to download a binaryTarget an invalid file remains in the artifacts cache.
Scope: Isolated to binary targets cache.
Risk: Low, scope is isolated, and the change has a corresponding test.
Testing: Automated with an existing test case refined.
Issue: rdar://123897276
Reviewer: @MaxDesiatov