Fix swift-symbolgraph-extract search paths
#7621
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rauhul
requested review from
bnbarham,
MaxDesiatov,
jakepetroules,
francescomikulis and
xedin
as code owners
|
builds on top of #7610 |
rauhul
force-pushed
the
swift-symbolgraph-extract-includes
branch
from
0cff9be to
359265e
Compare
Fixes and architecture and implementation bug where the include paths for swift symbolgraph extract were being determined inside build plan instead of by the target build description. This bug resulted in the wrong set of paths being determined. The new code moves the path determination logic into the proper target build descriptions and releverages the already computed include paths. The result of this is symbol graphs can be generated for Swift and C targets properly now without duplicate module in the search paths and with correct `-fmodule` usage.
rauhul
force-pushed
the
swift-symbolgraph-extract-includes
branch
from
359265e to
4f06914
Compare
xedin
reviewed
Jun 3, 2024
|
@swift-ci test |
|
@swift-ci test windows |
|
@swift-ci test |
|
@swift-ci test windows |
MaxDesiatov
changed the title
swift-symbolgraph-extract search paths
MaxDesiatov
approved these changes
Jun 4, 2024
rauhul
added a commit
that referenced
this pull request
Jun 12, 2024
Fixes an architecture and implementation bug where the include paths for `swift-symbolgraph-extract` were being determined inside build plan instead of by the target build description. This bug resulted in the wrong set of paths being determined. The new code moves the path determination logic into the proper target build descriptions and releverages the already computed include paths. The result of this is symbol graphs can be generated for Swift and C targets properly now without duplicate module in the search paths and with correct `-fmodule` usage.
rauhul
added a commit
that referenced
this pull request
Jun 13, 2024
Fixes an architecture and implementation bug where the include paths for `swift-symbolgraph-extract` were being determined inside build plan instead of by the target build description. This bug resulted in the wrong set of paths being determined. The new code moves the path determination logic into the proper target build descriptions and releverages the already computed include paths. The result of this is symbol graphs can be generated for Swift and C targets properly now without duplicate module in the search paths and with correct `-fmodule` usage.
rauhul
added a commit
that referenced
this pull request
Jun 13, 2024
Fixes an architecture and implementation bug where the include paths for `swift-api-digester` were being determined inside build plan instead of by the target build description. This is effectively the same change as #7621 but for api-digester rather than symbolgraph-extract. This commit also leaves hooks in to enable api-digester on clang modules as a future improvement.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an architecture and implementation bug where the include paths
for
swift-symbolgraph-extractwere being determined inside build planinstead of by the target build description. This bug resulted in the
wrong set of paths being determined.
The new code moves the path determination logic into the proper target
build descriptions and releverages the already computed include paths.
The result of this is symbol graphs can be generated for Swift and C
targets properly now without duplicate module in the search paths and
with correct
-fmoduleusage.