Bring back experimental-sdk as deprecated for compatibility
#7512
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are enough users of this command and corresponding options on `swift build` in the wild. These should be deprecated first before removing.
MaxDesiatov
added
cross-compilation
swift build
|
@swift-ci test |
bnbarham
approved these changes
Apr 29, 2024
| @@ -533,6 +533,12 @@ let package = Package( | |||
| dependencies: ["Commands", "SwiftSDKCommand"], | |||
| exclude: ["CMakeLists.txt"] | |||
| ), | |||
| .executableTarget( | |||
There was a problem hiding this comment.
Unfortunate we need to keep the executable here :(
MaxDesiatov
added a commit
that referenced
this pull request
May 1, 2024
…ounterparts (#7515) Cherry-pick of #7512, #7507, and #7517. **Explanation**: Since [SE-0387](https://github.com/apple/swift-evolution/blob/main/proposals/0387-cross-compilation-destinations.md) was accepted and available in Swift 5.9 and Swift 5.10, it's time to deprecate relevant CLI with the `experimental` prefix. There are enough users of this command and corresponding options on `swift build` in the wild, which means those should be deprecated first before removing. **Scope**: isolated to `swift sdk` command and 2 Swift SDK options on `swift build`. **Risk**: low, these commands options have no impact on `swift build` outside of cross-compilation use cases. **Testing**: added new end-to-end tests in `SDKCommandTests` in #7517 cherry-picked here. **Issue**: N/A **Reviewer**: @bnbarham
furby-tm
pushed a commit
to wabiverse/swift-package-manager
that referenced
this pull request
May 15, 2024
…ang#7512) There are enough users of this command and corresponding options on `swift build` in the wild. These should be deprecated first before removing.
furby-tm
pushed a commit
to wabiverse/swift-package-manager
that referenced
this pull request
May 15, 2024
…ang#7512) There are enough users of this command and corresponding options on `swift build` in the wild. These should be deprecated first before removing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are enough users of this command and corresponding options on
swift buildin the wild. These should be deprecated first before removing.