[NFC] Remove TSCBasic.InMemoryFileSystem dependency
#7484
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should prevent possible regressions in how this argument is handled.
Since #7483 this type is implemented in SwiftPM.
MaxDesiatov
added
test suite
xedin
force-pushed
the
maxd/test-toolchain-argument
branch
from
a68d7cf to
a7f8121
Compare
…xd/remove-tscbasic-inmemory-fs # Conflicts: # Sources/Basics/FileSystem/InMemoryFileSystem.swift # Sources/CoreCommands/SwiftCommandState.swift # Sources/PackageModel/UserToolchain.swift # Sources/SPMTestSupport/Toolchain.swift # Sources/Workspace/Workspace.swift # Tests/CommandsTests/SwiftCommandStateTests.swift # Tests/PackageModelTests/PackageModelTests.swift # Tests/SourceControlTests/InMemoryGitRepositoryTests.swift
|
@swift-ci test |
|
@swift-ci test |
MaxDesiatov
requested review from
jakepetroules and
francescomikulis
as code owners
|
@swift-ci test |
|
@swift-ci test windows |
MaxDesiatov
changed the title
TSCBasic.InMemoryFileSystem dependencyTSCBasic.InMemoryFileSystem dependency
|
@swift-ci test windows |
…xd/remove-tscbasic-inmemory-fs # Conflicts: # Tests/BuildTests/CrossCompilationBuildPlanTests.swift # Tests/CommandsTests/MermaidPackageSerializerTests.swift # Tests/LLBuildManifestTests/LLBuildManifestTests.swift
|
@swift-ci test |
xedin
approved these changes
Jul 2, 2024
|
@swift-ci test windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
As we'd like to quickly iterate on asyncification of our file system code and since TSC package is deprecated we should reduce our number of dependencies on it.
Modifications:
Removed
import class TSCBasic.InMemoryFileSystemstatements.Result:
We have less dependencies on the TSC package.