Skip to content

Conversation

@MaxDesiatov
Copy link
Contributor

rdar://118081439

@MaxDesiatov
Copy link
Contributor Author

@MaxDesiatov
Copy link
Contributor Author

1 similar comment
@MaxDesiatov
Copy link
Contributor Author

@MaxDesiatov MaxDesiatov changed the title Bump swift-argument-parser to 1.3.1 Bump swift-argument-parser to 1.4.0 May 29, 2024
@MaxDesiatov
Copy link
Contributor Author

@MaxDesiatov MaxDesiatov requested review from shahmishal and removed request for tomerd June 28, 2024 19:40
…o maxd/bump-argument-parser

# Conflicts:
#	Sources/PackageGraph/ModulesGraph+Loading.swift
@MaxDesiatov
Copy link
Contributor Author

}

func testUsage() async throws {
throw XCTSkip("rdar://131126477")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why? The reason for skipping is opaque to non apple contributors without a comment

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a regression in ArgumentParser 1.4.0 that won't allow this test to pass.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure but what's the failure, because if it's noted in source and linked to a GitHub issue then others can contribute more easily.

@MaxDesiatov
Copy link
Contributor Author

@MaxDesiatov
Copy link
Contributor Author

@shahmishal shahmishal merged commit 5e54c6b into main Jul 9, 2024
@shahmishal shahmishal deleted the maxd/bump-argument-parser branch July 9, 2024 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Changes to dependencies and relevant checks

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants