Fix sendability warnings in URLSessionHTTPClient
#7441
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Achieved by converting `DownloadTask` and `DataTask` to value types and adding more `Sendable` annotations where needed.
|
@swift-ci test |
|
@swift-ci test |
|
@swift-ci test |
MaxDesiatov
commented
Apr 8, 2024
| @@ -12,8 +12,6 @@ | |||
|
|
|||
| import Basics | |||
|
|
|||
| import Build | |||
There was a problem hiding this comment.
Unrelated warning, but probably not worth a separate one-liner PR, so chucking that in here instead.
|
@swift-ci test windows |
xedin
approved these changes
Apr 9, 2024
| @@ -312,7 +312,7 @@ extension LegacyHTTPClient { | |||
| headers: HTTPClientHeaders = .init(), | |||
| options: Request.Options = .init(), | |||
| observabilityScope: ObservabilityScope? = .none, | |||
| completion: @escaping (Result<Response, Error>) -> Void | |||
| completion: @Sendable @escaping (Result<Response, Error>) -> Void | |||
There was a problem hiding this comment.
Stylistic nit: I think the preferred ordering for function types is @escaping @Sendable
furby-tm
pushed a commit
to wabiverse/swift-package-manager
that referenced
this pull request
May 15, 2024
Achieved by converting `DownloadTask` and `DataTask` to value types and adding more `Sendable` annotations where needed.
furby-tm
pushed a commit
to wabiverse/swift-package-manager
that referenced
this pull request
May 15, 2024
Achieved by converting `DownloadTask` and `DataTask` to value types and adding more `Sendable` annotations where needed.
bnbarham
pushed a commit
to bnbarham/swift-package-manager
that referenced
this pull request
May 18, 2024
Achieved by converting `DownloadTask` and `DataTask` to value types and adding more `Sendable` annotations where needed. (cherry picked from commit 549d781)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Converted
DownloadTaskandDataTaskto value types and added moreSendableannotations where needed.