Skip to content

Use structured concurrency in PackageLoadingTests #7359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 23, 2024

Conversation

MaxDesiatov
Copy link
Contributor

This is a stripped down version of #6624 that modifies only the test suite and doesn't make any substantial to ManifestLoader.swift other than providing an async overload in extension ManifestLoaderProtocol that uses withCheckedThrowingContinuation to bridge into the existing implementation.

@MaxDesiatov MaxDesiatov added enhancement concurrency test suite improvements to SwiftPM test suite package manifests changes to package manifest APIs labels Feb 22, 2024
@MaxDesiatov MaxDesiatov self-assigned this Feb 22, 2024
@MaxDesiatov
Copy link
Contributor Author

@swift-ci test

@MaxDesiatov
Copy link
Contributor Author

@swift-ci test windows

1 similar comment
@MaxDesiatov
Copy link
Contributor Author

@swift-ci test windows

@MaxDesiatov MaxDesiatov requested a review from weissi February 23, 2024 11:19
Copy link
Contributor

@weissi weissi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@MaxDesiatov MaxDesiatov merged commit 2a01f6e into main Feb 23, 2024
@MaxDesiatov MaxDesiatov deleted the maxd/package-loading-concurrency branch February 23, 2024 14:13
furby-tm pushed a commit to wabiverse/swift-package-manager that referenced this pull request May 15, 2024
This is a stripped down version of
swiftlang#6624 that modifies
only the test suite and doesn't make any substantial to
`ManifestLoader.swift` other than providing an `async` overload in
`extension ManifestLoaderProtocol` that uses
`withCheckedThrowingContinuation` to bridge into the existing
implementation.
furby-tm pushed a commit to wabiverse/swift-package-manager that referenced this pull request May 15, 2024
This is a stripped down version of
swiftlang#6624 that modifies
only the test suite and doesn't make any substantial to
`ManifestLoader.swift` other than providing an `async` overload in
`extension ManifestLoaderProtocol` that uses
`withCheckedThrowingContinuation` to bridge into the existing
implementation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
concurrency enhancement package manifests changes to package manifest APIs test suite improvements to SwiftPM test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants