Use a different path extension for swift-testing builds #7163
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grynspan
requested review from
MaxDesiatov,
neonichu and
tomerd
as code owners
Contributor
Author
|
@swift-ci please test |
MaxDesiatov
reviewed
Dec 4, 2023
MaxDesiatov
reviewed
Dec 4, 2023
Contributor
Author
|
Looks like this is blocked on #7123. |
MaxDesiatov
approved these changes
Dec 4, 2023
Contributor
|
@swift-ci test |
grynspan
force-pushed
the
jgrynspan/different-extension-for-swift-testing-builds
branch
from
ccb4847 to
f409f06
Compare
Contributor
Author
|
@swift-ci please test |
Contributor
Author
|
@swift-ci please test Windows |
Contributor
Author
|
@swift-ci please test |
1 similar comment
Contributor
Author
|
@swift-ci please test |
Contributor
Author
|
Today is not off to a great start! 🥲 |
Contributor
Author
|
@swift-ci please test |
Contributor
Author
|
@swift-ci please test Windows |
MaxDesiatov
changed the title
grynspan
force-pushed
the
jgrynspan/different-extension-for-swift-testing-builds
branch
from
473bf33 to
01867a7
Compare
Contributor
Author
|
@swift-ci please test |
Contributor
Author
|
@swift-ci please test Windows |
grynspan
force-pushed
the
jgrynspan/different-extension-for-swift-testing-builds
branch
from
01867a7 to
473bf33
Compare
Currently, SwiftPM is using the same path to build swift-testing and XCTest content. This works about 90% of the time because we only need one or the other at any given moment, but it causes some workflows to fail on Linux because the build system sees the existing build product and assumes the build has already completed, which is incorrect. Darwin doesn't seem to be affected (because the XCTest build product is a bundle rather than an executable.) This PR selects a different path extension, ".swift-testing", for swift-testing's build product.
grynspan
force-pushed
the
jgrynspan/different-extension-for-swift-testing-builds
branch
from
473bf33 to
78b9041
Compare
Contributor
Author
|
@swift-ci please test |
Contributor
Author
|
@swift-ci please test Windows |
grynspan
deleted the
jgrynspan/different-extension-for-swift-testing-builds
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, SwiftPM is using the same path to build swift-testing and XCTest content. This works about 90% of the time because we only need one or the other at any given moment, but it causes some workflows to fail on Linux because the build system sees the existing build product and assumes the build has already completed, which is incorrect. Darwin doesn't seem to be affected (because the XCTest build product is a bundle rather than an executable.)
This PR selects a different path extension, ".swift-testing", for swift-testing's build product.