tests: loosen expectations on WorkspaceTests #6689
Conversation
Some targets use pre-compiled manifests instead of interpretation. Such a manifest will copy the `Package.swift` to `manifest.swift` and change the location. As a result, the prefix expectation on the filename will fail. Loosen the condition to accommodate the implementation.
compnerd
requested review from
abertelrud,
neonichu,
tomerd and
MaxDesiatov
as code owners
|
@swift-ci please smoke test |
|
I think this is because we don't yet generate a proper VFS for manifest loading on Windows: #5980 -- can we |
|
Oh, this is related to VFS stuff? Do you know how difficult it would be to just fix that? I think that the problem was that we didn't invoke the |
| diagnostic: .contains( | ||
| "\(pkgDir.appending("Package.swift")):4:8: error: An error in MyPkg" | ||
| ), | ||
| diagnostic: .contains(":4:8: error: An error in MyPkg"), |
There was a problem hiding this comment.
Maybe keep the Package.swift part?
There was a problem hiding this comment.
Unfortunately the name of the file also is different: manifest.swift vs Package.swift
I am not 100% sure, but probably not the difficult? |
Some targets use pre-compiled manifests instead of interpretation. Such a manifest will copy the
Package.swifttomanifest.swiftand change the location. As a result, the prefix expectation on the filename will fail. Loosen the condition to accommodate the implementation.