wip: adopt swift-system path #6537
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neonichu
reviewed
May 10, 2023
| @@ -38,13 +42,17 @@ public typealias TSCAbsolutePath = TSCBasic.AbsolutePath | |||
| /// that evaluates the tilde; the `cd` command receives an absolute path). | |||
| public struct AbsolutePath: Hashable, Sendable { | |||
| /// Root directory (whose string representation is just a path separator). | |||
| public static let root = Self(TSCAbsolutePath.root) | |||
| public static let root = Self(FilePath("/")) | |||
There was a problem hiding this comment.
It looks like there's something called FilePath.Root which can also represent the multiple roots on Windows. Seems like we should switch to that, at least eventually.
There was a problem hiding this comment.
@compnerd I guess we will need to #if here for windows. what would be the right representation of windows root here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.