Run build tool plugins for C-family targets #6516
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
neonichu
commented
May 3, 2023
| // MARK: - Compilation | ||
|
|
||
| extension LLBuildManifestBuilder { | ||
| private func addBuildToolPlugins(_ target: TargetBuildDescription) throws { |
There was a problem hiding this comment.
This is just extracted from computeSwiftCompileCmdInputs()
neonichu
commented
May 3, 2023
|
|
||
| /// Shared functionality between `ClangTargetBuildDescription` and `SwiftTargetBuildDescription` with the eventual hope of having a single type. | ||
| struct SharedTargetBuildDescription { | ||
| static func computePluginGeneratedFiles( |
There was a problem hiding this comment.
This is just extracted from SwiftTargetBuildDescription
tomerd
approved these changes
May 3, 2023
forgot to add the new file to the CMake build |
neonichu
force-pushed
the
run-build-tool-plugins-for-c-family-targets
branch
from
88582bf to
cf2592f
Compare
|
@swift-ci please smoke test |
|
@swift-ci test windows |
MaxDesiatov
reviewed
May 4, 2023
Sources/Build/BuildDescription/ClangTargetBuildDescription.swift
Outdated
Show resolved
Hide resolved
MaxDesiatov
approved these changes
May 4, 2023
neonichu
force-pushed
the
run-build-tool-plugins-for-c-family-targets
branch
2 times, most recently
from
6b2f4cf to
8c4b5b2
Compare
|
@swift-ci please smoke test |
I may have accidentally removed an import during rebase. |
While we intentionally don't support generating C sources from plugins today since we haven't figured out how to deal with headers etc, not running plugins at all without any diagnostics whatsoever seems like an implementation oversight based on the fact that we have two completely different implementations for Swift and C-family targets (which is something we also need to rectify at some point). With this change, we're running build-tool plugins in the exact same way as we are doing it for Swift targets. We are only doing this for packages with tools-version 5.9 or higher in order to have any unintentional impact on existing packages. rdar://101671614 Co-authored-by: Max Desiatov <m_desiatov@apple.com>
neonichu
force-pushed
the
run-build-tool-plugins-for-c-family-targets
branch
from
8c4b5b2 to
7abffec
Compare
|
@swift-ci please smoke test |
|
@swift-ci please smoke test windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While we intentionally don't support generating C sources from plugins today since we haven't figured out how to deal with headers etc, not running plugins at all without any diagnostics whatsoever seems like an implementation oversight based on the fact that we have two completely different implementations for Swift and C-family targets (which is something we also need to rectify at some point).
With this change, we're running build-tool plugins in the exact same way as we are doing it for Swift targets. We are only doing this for packages with tools-version 5.9 or higher in order to have any unintentional impact on existing packages.
rdar://101671614