Fix warnings #6496
Merged
Fix warnings #6496
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neonichu
requested review from
abertelrud,
tomerd and
MaxDesiatov
as code owners
|
@swift-ci please smoke test |
|
Related: I think we should do cleanups like swiftlang/swift-tools-support-core#413 in reverse order in the future. First get the known clients in the toolchain (or at a minimum any of SwiftPM's dependencies) off the API we'd like to deprecate and then deprecate it. If we do it in the normal order, we end up with tons of warnings in the meantime, e.g. right now there are a total of 188 warnings when building SwiftPM which are related to this. |
tomerd
approved these changes
Apr 29, 2023
These are already fixed in the |
MaxDesiatov
approved these changes
Apr 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remaining warnings:
GenerateLinuxMain, should get fixed by Commands/Utilities: removeGenerateLinuxMain#6490swiftpm-xctest-helpersince XCTest on macOS has a 13.0 deployment target. Nothing we can really do right now, but we should switch our deployment target to 13.0 as soon as we can.ObservabilityScope.makeDiagnosticsHandler()which is needed for compatibility with swift-driver