Skip to content

Supplemental fix for XcodeProjectPlugin support in package init template #6451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 18, 2023
Merged

Supplemental fix for XcodeProjectPlugin support in package init template #6451

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions Sources/Workspace/InitPackage.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -422,7 +422,7 @@ public final class InitPackage {

extension \(typeName): XcodeBuildToolPlugin {
// Entry point for creating build commands for targets in Xcode projects.
func createBuildCommands(context: XcodePluginContext, target: XcodeTarget) async throws -> [Command] {
func createBuildCommands(context: XcodePluginContext, target: XcodeTarget) throws -> [Command] {
// Find the code generator tool to run (replace this with the actual one).
let generatorTool = try context.tool(named: "my-code-generator")

Expand Down Expand Up @@ -469,9 +469,9 @@ public final class InitPackage {
#if canImport(XcodeProjectPlugin)
import XcodeProjectPlugin

extension MyCommandPlugin: CommandPlugin {
extension MyCommandPlugin: XcodeCommandPlugin {
// Entry point for command plugins applied to Xcode projects.
func performCommand(context: XcodePluginContext, arguments: [String]) async throws {
func performCommand(context: XcodePluginContext, arguments: [String]) throws {
print("Hello, World!")
}
}
Expand Down
2 changes: 2 additions & 0 deletions Tests/WorkspaceTests/InitTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,6 +179,7 @@ class InitTests: XCTestCase {
XCTAssertMatch(sourceContents, .contains("struct MyCommandPlugin: CommandPlugin"))
XCTAssertMatch(sourceContents, .contains("performCommand(context: PluginContext"))
XCTAssertMatch(sourceContents, .contains("import XcodeProjectPlugin"))
XCTAssertMatch(sourceContents, .contains("extension MyCommandPlugin: XcodeCommandPlugin"))
XCTAssertMatch(sourceContents, .contains("performCommand(context: XcodePluginContext"))
}
}
Expand Down Expand Up @@ -212,6 +213,7 @@ class InitTests: XCTestCase {
XCTAssertMatch(sourceContents, .contains("struct MyBuildToolPlugin: BuildToolPlugin"))
XCTAssertMatch(sourceContents, .contains("createBuildCommands(context: PluginContext"))
XCTAssertMatch(sourceContents, .contains("import XcodeProjectPlugin"))
XCTAssertMatch(sourceContents, .contains("extension MyBuildToolPlugin: XcodeBuildToolPlugin"))
XCTAssertMatch(sourceContents, .contains("createBuildCommands(context: XcodePluginContext"))
}
}
Expand Down