Skip to content

Conversation

@yim-lee
Copy link
Contributor

@yim-lee yim-lee commented Apr 4, 2023

rdar://107005076

@yim-lee
Copy link
Contributor Author

yim-lee commented Apr 4, 2023

@swift-ci please smoke test

@MaxDesiatov
Copy link
Contributor

@swift-ci smoke test macos

@MaxDesiatov
Copy link
Contributor

@swift-ci test windows

(i.e., one of username/password or access token) or when prompted:

```bash
$ swift package-registry login https://packages.example.com
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we also support swift package-registry login packages.example.com (without scheme)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently no. URL scheme is required and must be https.

Copy link
Contributor

@tomerd tomerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is fantastic. thanks for putting together. left some tiny comments

@tomerd
Copy link
Contributor

tomerd commented Apr 4, 2023

cc @zkiraly

yim-lee and others added 2 commits April 4, 2023 13:16
Co-authored-by: tomer doron <tomer@apple.com>
@yim-lee
Copy link
Contributor Author

yim-lee commented Apr 4, 2023

@swift-ci please smoke test

@yim-lee
Copy link
Contributor Author

yim-lee commented Apr 4, 2023

@swift-ci please test Windows platform

2 similar comments
@yim-lee
Copy link
Contributor Author

yim-lee commented Apr 4, 2023

@swift-ci please test Windows platform

@yim-lee
Copy link
Contributor Author

yim-lee commented Apr 4, 2023

@swift-ci please test Windows platform

SwiftPM can deduplicate packages by performing a
[lookup on the source control URL](https://github.com/apple/swift-package-manager/blob/main/Documentation/Registry.md#endpoint-5)
(e.g., `https://github.com/mona/LinkedList`) to see if it is associated with
any package identifier (e.g., `mona.LinkedList`).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<3

@yim-lee
Copy link
Contributor Author

yim-lee commented Apr 4, 2023

@swift-ci please test Windows platform

@yim-lee
Copy link
Contributor Author

yim-lee commented Apr 5, 2023

@swift-ci please smoke test macOS

@yim-lee yim-lee merged commit b35db9e into swiftlang:main Apr 5, 2023
@yim-lee yim-lee deleted the registry-docs branch April 5, 2023 03:25
yim-lee added a commit to yim-lee/swift-package-manager that referenced this pull request Apr 5, 2023
* Documentation on registry usage

rdar://107005076

* Update Documentation/PackageRegistryUsage.md

Co-authored-by: tomer doron <tomer@apple.com>

* Address review feedback

---------

Co-authored-by: tomer doron <tomer@apple.com>
yim-lee added a commit that referenced this pull request Apr 6, 2023
* Documentation on registry usage

rdar://107005076

* Update Documentation/PackageRegistryUsage.md



* Address review feedback

---------

Co-authored-by: tomer doron <tomer@apple.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants