Add support for creating a macro package #6250
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce `swift package init --type macro` to create a new package that defines a macro. It contains: * A macro implementation target * A library that provides the macro declaration for use by clients * A "client" executable that imports the library and uses the macro * A test target for debugging the macro implementation Note that the test target runs into linking issues because the macro implementation target is an executable, not a library. I believe this is a known issue. Tracked by rdar://106468626.
|
@swift-ci please test |
|
cc @TimTr @bitjammer |
|
@swift-ci please smoke test |
|
macOS failure looks unrelated? |
|
yes the macOS self hosted job is defunct due to old Xcode cc @shahmishal |
neonichu
reviewed
Mar 9, 2023
neonichu
reviewed
Mar 9, 2023
| } else if packageType == .macro { | ||
| pkgParams.append(""" | ||
| dependencies: [ | ||
| .package(url: "https://github.com/apple/swift-syntax.git", branch: "main"), |
There was a problem hiding this comment.
We should make sure to have a follow-up task to change this from main once we have a concrete version that people should be using.
There was a problem hiding this comment.
Right. We should get that once we branch for Swift 5.9.
neonichu
reviewed
Mar 9, 2023
neonichu
reviewed
Mar 9, 2023
| // We do this to avoid adding unnecessary constraints to patch versions, if | ||
| // the package really needs it, they should add it manually. | ||
| let version = InitPackage.newPackageToolsVersion.zeroedPatch | ||
| let version = packageType == .macro ? ToolsVersion.vNext |
There was a problem hiding this comment.
Also something to keep in mind to update later.
There was a problem hiding this comment.
Right, we'll update this when the macro target gets a proper Swift version instead of 999.
neonichu
reviewed
Mar 9, 2023
| case .macro: | ||
| content = """ | ||
| // The Swift Programming Language | ||
| // https://docs.swift.org/swift-book |
There was a problem hiding this comment.
Maybe a more concrete reference to macros once we have it?
|
@swift-ci please smoke test |
neonichu
approved these changes
Mar 9, 2023
abertelrud
added a commit
that referenced
this pull request
Mar 27, 2023
abertelrud
added a commit
that referenced
this pull request
Mar 27, 2023
… in #6250 The loss of this newline seems to have been unintentional and changed the behaviour from what it was in SwiftPM 5.8. This commit restores it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce
swift package init --type macroto create a new package that defines a macro. It contains:Note that the test target runs into linking issues because the macro implementation target is an executable, not a library. I believe this is a known issue.
Tracked by rdar://106468626.