[wip] streaming uploads #6161
Open
[wip] streaming uploads #6161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomerd
force-pushed
the
feature/registry-publish-7
branch
2 times, most recently
from
07807cd to
238a77f
Compare
weissi
reviewed
Feb 16, 2023
| self.dataToWrite = .none | ||
| inputStream.close() | ||
| } else { | ||
| let bytesWritten = self.outputStream.write(buffer, maxLength: bytesRead) |
There was a problem hiding this comment.
what happens with the bytes that didn't get written? (i.e. bytesWritten < bytesRead)?
There was a problem hiding this comment.
great catch. is there a way to move the reader index back? otherwise I can buffer them
There was a problem hiding this comment.
No, you can't unread. You'll need to buffer them and you'll need to stop reading until you're done with the previous writes.
tomerd
commented
Feb 17, 2023
| } | ||
| completionHandler(task.inputStream) | ||
| // FIXME: serious hack here | ||
| RunLoop.current.run(until: Date(timeIntervalSinceNow: 10000.0)) |
There was a problem hiding this comment.
@weissi any ideas on why the stream is not going notified unless I run the .current runloop manually?
There was a problem hiding this comment.
that almost certainly means that you're blocking the runloop somewhere.
tomerd
force-pushed
the
feature/registry-publish-7
branch
2 times, most recently
from
17c41bc to
04c0c7b
Compare
motivation: improve upload to stream the content of the files instead of loading them to memory changes: * introduce new upload requiest type * implement stream upload hanlding with URLSession * implement an upload stream provider for registry publishing TODO: * add tests
tomerd
force-pushed
the
feature/registry-publish-7
branch
from
04c0c7b to
e896adf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
motivation: improve upload to stream the content of the files instead of loading them to memory
changes:
TODO: