[5.7] Build plugin executables with debug symbols #5665
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
|
Hm, looks like the self-hosted job also reproduces the issue, so it affects the 5.6 compiler as well? |
neonichu
force-pushed
the
build-plugin-executables-with-debug-symbols-5.7
branch
from
eae23ec to
4a39134
Compare
|
Going to try to disable the part of the test that fails when passing |
|
@swift-ci please smoke test |
|
I guess the issue is that this would be swallowing legitimate diagnostics, so we have a tradeoff between that and passing |
This seems like the better default until we might add a dedicated debugging feature for plugins.
neonichu
force-pushed
the
build-plugin-executables-with-debug-symbols-5.7
branch
from
4a39134 to
726d3cb
Compare
|
@swift-ci please smoke test |
tomerd
approved these changes
Jul 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems like the better default until we might add a dedicated debugging feature for plugins.
This is the same as #5659 for 5.7, but since we are seeing a test issue there that seems to be limited to
mainpotentially and that is outside of our control, I'm going to try to land this in 5.7 first given the timeline.