Revert "adopt swift-collections (#3632)" #3677
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 2019464.
neonichu
requested review from
abertelrud,
friedbunny and
tomerd
as code owners
|
@swift-ci please smoke test |
tomerd
approved these changes
Aug 18, 2021
|
we can potentially fix forward once apple/swift-collections#86 is merged and 0.6 is out |
Fixing forward would be nicer if we can do it, to reduce churn. My understanding is that it's close? |
tomerd
added a commit
that referenced
this pull request
Aug 20, 2021
tomerd
added a commit
that referenced
this pull request
Sep 13, 2021
tomerd
added a commit
that referenced
this pull request
Oct 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 2019464.
The currently existing dependency on swift-collections-benchmark is causing some issues which we did not catch until now, so we'll revert for now.