Add functional test for binary with moved resources #3472
Conversation
ffried
requested review from
abertelrud,
friedbunny,
neonichu and
tomerd
as code owners
ffried
force-pushed
the
tests/add_functional_moved_resources_test
branch
from
fb4ba1d to
ca789b2
Compare
There was a problem hiding this comment.
Firstly, thank you so much for adding this test!
Comments inline. The major one is that it's better to move the bundle rather than copying, so that the one in the build directory can't accidentally be found. The the overall structure of the test here is good, I think!
Thanks again!
|
@abertelrud Thanks for the review! I've just pushed the changes I've made and replied to your comments inline. |
|
@swift-ci please smoke test |
|
@abertelrud Looking at the Linux CI failures, I guess I need to build each product separately after all... 👀 |
ffried
force-pushed
the
tests/add_functional_moved_resources_test
branch
from
c9f1349 to
16320dc
Compare
|
@abertelrud Using |
|
@swift-ci please smoke test |
|
@swift-ci please smoke test |
|
Thanks @tomerd! |
|
Thanks, this looks great to me. All good to merge it? |
|
All good from my side, yea. 👍 Btw. should I open a cherry pick PR against release/5.5 with this as well? |
|
thanks @ffried no need in a 5.5 cherry pick imo as this is focused on a test and no functionality added |
* Add functional tests for binary with moved resources * Remove .gitignore for resources fixtures * Use local file system for file operations * Build each product separately
Add a functional test that produces a binary with resources, moves the binary and its resources and executes it.
Motivation:
Attempts to add the test that was described in this comment on #3463.
This would resolve https://bugs.swift.org/browse/SR-14592.
Modifications:
Add a functional test by adding a new Fixture and test method.
Result:
There's a test case that tests that binaries with resources can be moved to a different place and still find their resources (as long as they're placed next to the binary).