SR-1005: [Foundation] Replace posix_spawn by NSTask

Sources/Build/misc.swift

@@ -9,7 +9,7 @@
 */
 
 import func POSIX.getenv
-import func POSIX.popen
+import func Utility.popen
 import func POSIX.mkdir
 import PackageType
 import Utility
@@ -24,7 +24,7 @@ public protocol Toolchain {
 func platformFrameworksPath() throws -> String {
     // Lazily compute the platform the first time it is needed.
     struct Static {
-        static let value = { try? POSIX.popen(["xcrun", "--sdk", "macosx", "--show-sdk-platform-path"]) }()
+        static let value = { try? Utility.popen(["xcrun", "--sdk", "macosx", "--show-sdk-platform-path"]) }()
     }
     guard let popened = Static.value, let chuzzled = popened.chuzzle() else {
         throw Error.InvalidPlatformPath

Sources/ManifestSerializer/Manifest+parse.swift

@@ -14,6 +14,7 @@ import PackageDescription
 import PackageType
 import Utility
 import func Utility.fopen
+import Foundation
 
 extension Manifest {
     public init(path pathComponents: String..., baseURL: String, swiftc: String, libdir: String) throws {
@@ -66,17 +67,17 @@ private func parse(path manifestPath: String, swiftc: String, libdir: String) th
 #endif
     cmd += [manifestPath]
 
-    //Create and open a temporary file to write toml to
-    let filePath = Path.join(manifestPath.parentDirectory, ".Package.toml")
-    let fp = try fopen(filePath, mode: .Write)
-    defer { fp.closeFile() }
-
-    //Pass the fd in arguments
-    cmd += ["-fileno", "\(fp.fileDescriptor)"]
-    try system(cmd)
-
-    let toml = try fopen(filePath).reduce("") { $0 + "\n" + $1 }
-    try unlink(filePath) //Delete the temp file after reading it
+    //Previous implementation used a temporary file, however NSTask doesn't
+    //allow child process to access parent's file descriptors. So instruct
+    //swiftc to dump the package information on stdout.
+    #if os(OSX) || os(iOS)
+        let handle = NSFileHandle.standardOutput()
+    #else
+        let handle = NSFileHandle.fileHandleWithStandardOutput()
+    #endif
+
+    cmd += ["-fileno",  String(handle.fileDescriptor)]
+    let toml = try Utility.popen(cmd)
 
     return toml != "" ? toml : nil
 }

Sources/POSIX/Error.swift

@@ -108,7 +108,7 @@ extension SystemError: CustomStringConvertible {
 
 
 public enum Error: ErrorProtocol {
-    case ExitStatus(Int32, [String])
+    case ExitStatus(Int32, String, [String])
     case ExitSignal
 }
 
@@ -120,8 +120,8 @@ public enum ShellError: ErrorProtocol {
 extension Error: CustomStringConvertible {
     public var description: String {
         switch self {
-        case .ExitStatus(let code, let args):
-            return "exit(\(code)): \(prettyArguments(args))"
+        case .ExitStatus(let code, let path, let args):
+            return "exit(\(code)): \(path) \(prettyArguments(args))"
 
         case .ExitSignal:
             return "Child process exited with signal"

Sources/Utility/Error.swift

@@ -15,6 +15,7 @@ public enum Error: ErrorProtocol {
     case UnicodeEncodingError
     case CouldNotCreateFile(path: String)
     case FileDoesNotExist(path: String)
+    case UnknownCommand(arg0: String)
 }
 
 extension Error: CustomStringConvertible {
@@ -28,6 +29,7 @@ extension Error: CustomStringConvertible {
         case .UnicodeEncodingError: return "Could not encode string into unicode"
         case .CouldNotCreateFile(let path): return "Could not create file: \(path)"
         case .FileDoesNotExist(let path): return "File does not exist: \(path)"
+        case .UnknownCommand(let arg0): return "Command is not found on the PATH: \(arg0)"
         }
     }
 }

Sources/Utility/Platform.swift

@@ -8,8 +8,6 @@
  See http://swift.org/CONTRIBUTORS.txt for Swift project authors
 */
 
-import func POSIX.popen
-
 public enum Platform {
     case Darwin
     case Linux(LinuxFlavor)