Skip to content

fix build after #242 #244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

fix build after #242 #244

wants to merge 1 commit into from

Conversation

goloveychuk
Copy link
Contributor

after #242 master is not compilling

@aciidgh
Copy link
Contributor

aciidgh commented Apr 7, 2016

I don't think this is desired, master should be compiling wrt swift master and not necessarily the toolchain. #242 was done due to proposal SE-0046 which is merged to swift master but isn't in toolchain yet. However I do think #242 should have been CI'ed.

@goloveychuk
Copy link
Contributor Author

So you saying that

func f(_ arg: Int)
f(arg: 2)

will build in swift/master?
My pr mostly fix this mistakes

@mxcl
Copy link
Contributor

mxcl commented Apr 7, 2016

I can build swiftpm master against swift master without this patch.

@goloveychuk
Copy link
Contributor Author

@mxcl ok, if not needed - can close it. New toolchain will be with master swift. So it wouldn't a problem

@goloveychuk goloveychuk closed this Apr 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants