Ignore xcuserdata/ #2184
Merged
Ignore xcuserdata/ #2184
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci smoke test |
|
This is a bit complex :( I don't think we should ignore the entire directory by default since users might want to check in things like the mirror config file. Similarly, Xcode's xcshareddata directory is also probably worth checking in but there is nothing interesting right now (except maybe custom/modified schemes). However, it definitely makes sense to ignore the xcuserdata directory. I am curious what @neonichu thinks about this. |
|
Yeah I suspected so. I'll update it to |
Now that SwiftPM is more likely to checked in alongside with Xcode artifacts, ignore the commonly ignored Xcode artifacts.
dduan
force-pushed
the
ignore-dot-swiftpm
branch
from
2bc43f1 to
d444c08
Compare
|
@swift-ci smoke test |
jakepetroules
approved these changes
Jun 23, 2019
|
@swift-ci smoke test linux |
|
@dduan do you want to cherry-pick this to 5.1 branch? |
Merged
|
I just filed FB6569495 about this too, shared schemes get through this gitignore still, I'm not sure what the desired behavior is there |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that SwiftPM is more likely to checked in alongside with Xcode
artifacts, ignore the commonly ignored Xcode artifacts.