[swift-test] [BLOCKED by #143] Disambiguate Package.test targets #213
Conversation
| @@ -21,11 +21,14 @@ do { | |||
| usage() | |||
| case .Run(let xctestArg): | |||
| let dir = try directories() | |||
|
|
|||
| //FIXME find a reliable name to detect the name of the root test Package | |||
| let testPackageName = dir.root.basename | |||
There was a problem hiding this comment.
I'm all ears on how to pull the root package's name. We can always reparse the manifest, but for now it feels like an overkill. @mxcl?
There was a problem hiding this comment.
It's fine to reparse it for now. Premature optimization and all that.
|
We should add a Unit tests for it. |
|
@kostiakoval You're absolutely right, I'll add that. I just wanted to fix the root package name detection before I do so. |
|
@czechboy0 I've provided example project in the SR-989 that you could use for testing |
|
Ha, I knew I remembered this being fixed months ago. There actually is a test for this case, but previously |
czechboy0
changed the title
|
I think this PR dependent on #143 because you would need to invoke swift-test. |
|
@kostiakoval You're right! Waiting for #143 here then. |
czechboy0
changed the title
|
Merged: e702428 |
<rdar://problem/36587411> Better error-handling for single node builds
This tries to solve the same problem as #151.
This seems to work on OS X, I'm in the process of testing it on Linux.
! I need guidance on what the best way to pull the root package's name is. Currently I'm using the root folder's name, which of course isn't robust at all.
This aims to fix https://bugs.swift.org/browse/SR-989