Skip to content

Add new manifest option to swift package init #2106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 30, 2019

Conversation

neonichu
Copy link
Contributor

@neonichu neonichu commented Apr 30, 2019

This will just generate a manifest in the current directory. The contents will be the same as for initializing a library package.

That means the contents will likely not match the filesystem layout, but I think that is OK, this will still make it easier to add a manifest to an existing project. We can improve it in the future and make the generated content based on what is actually there on the filesystem.

rdar://problem/50347943

@neonichu neonichu requested a review from aciidgh April 30, 2019 20:50
@neonichu
Copy link
Contributor Author

@swift-ci please smoke test

Copy link
Contributor

@aciidgh aciidgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just needs linuxmain.

This will just generate a manifest in the current directory. The
contents will be the same as for initializing a library package.

That means the contents will likely not match the filesystem layout,
but I think that is OK, this will still make it easier to add a
manifest to an existing project. We can improve it in the future and
make the generated content based on what is actually there on the
filesystem.

rdar://problem/50347943
@neonichu neonichu force-pushed the init-with-manifest branch from ec13dd9 to 855a1f3 Compare April 30, 2019 20:54
@neonichu
Copy link
Contributor Author

@swift-ci please smoke test

@neonichu neonichu merged commit a8e8a4f into swiftlang:master Apr 30, 2019
@neonichu neonichu deleted the init-with-manifest branch April 30, 2019 21:50
neonichu added a commit to neonichu/swift-package-manager that referenced this pull request May 1, 2019
This will just generate a manifest in the current directory. The
contents will be the same as for initializing a library package.

That means the contents will likely not match the filesystem layout,
but I think that is OK, this will still make it easier to add a
manifest to an existing project. We can improve it in the future and
make the generated content based on what is actually there on the
filesystem.

rdar://problem/50347943
neonichu added a commit that referenced this pull request May 1, 2019
This will just generate a manifest in the current directory. The
contents will be the same as for initializing a library package.

That means the contents will likely not match the filesystem layout,
but I think that is OK, this will still make it easier to add a
manifest to an existing project. We can improve it in the future and
make the generated content based on what is actually there on the
filesystem.

rdar://problem/50347943
aemino pushed a commit to aemino/swift-package-manager that referenced this pull request Sep 14, 2019
This will just generate a manifest in the current directory. The
contents will be the same as for initializing a library package.

That means the contents will likely not match the filesystem layout,
but I think that is OK, this will still make it easier to add a
manifest to an existing project. We can improve it in the future and
make the generated content based on what is actually there on the
filesystem.

rdar://problem/50347943
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants